Accept EC PRIVATE KEY items in PEM files. #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
partim
requested review from
DRiKE,
density215 and
a team
and removed request for
DRiKE and
density215
ximon18
reviewed
Jan 3, 2024
| @@ -96,7 +96,7 @@ fn read_key(key_path: &Path) -> Result<PrivateKey, ExitError> { | |||
| })?; | |||
|
|
|||
| let bits = match item { | |||
| RSAKey(bits) | PKCS8Key(bits) => bits, | |||
| RSAKey(bits) | PKCS8Key(bits) | ECKey(bits) => bits, | |||
There was a problem hiding this comment.
I tested it locally like so:
$ openssl ecparam -name prime256v1 -genkey -noout -out /tmp/ec-private-key.pem
$ openssl ec -in /tmp/ec-private-key.pem -pubout -out /tmp/ec-public-key.pem
$ openssl req -new -x509 -key /tmp/ec-private-key.pem -out /tmp/ec-cert.pem -days 360
$ routinator -vvv server --http-tls 127.0.0.1:8443 --http-tls-cert /tmp/ec-cert.pem --http-tls-key /tmp/ec-private-key.pem
With Routinator 0.13.0 that resulted in an error:
[ERROR] TLS key file '/tmp/ec-private-key.pem' does not contain any usable keys.
With this PR there was no error and openssl shows the EC key in use:
$ true | openssl s_client -connect localhost:8443 2>&1 | openssl x509 -noout -text | grep Algorithm
Signature Algorithm: ecdsa-with-SHA256
Public Key Algorithm: id-ecPublicKey
Signature Algorithm: ecdsa-with-SHA256
ximon18
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for private keys marked as “EC PRIVATE KEY“ in the PEM files for TLS server configuration.
Fixes #908.