Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cargo.lock to Git. #17

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add Cargo.lock to Git. #17

merged 1 commit into from
Nov 5, 2024

Conversation

ximon18
Copy link
Member

@ximon18 ximon18 commented Nov 5, 2024

As dnst is a binary and because we do that for other binaries such as Routinator.

bal-e
bal-e approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@bal-e bal-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to update .gitignore or something too?

@ximon18
Copy link
Member Author

ximon18 commented Nov 5, 2024

Cargo.lock should not be added to .gitignore as changes to it should be added and committed to provide a known working combination of dependency versions.

I can't think of anything else impacted by adding Cargo.lock to the git repo.

@ximon18 ximon18 merged commit 24d22a9 into main Nov 5, 2024
28 checks passed
@ximon18 ximon18 deleted the missing-cargo-lock branch November 5, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bal-e bal-e bal-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ximon18 @bal-e