Small improvements for dig-compatible output. #38
+13
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/output/dig.rs
Outdated
Comment on lines
68
to
71
| opt.timeout().map_or("".to_string(), |t| format!( | ||
| "{:.1}", | ||
| Duration::from(t).as_secs_f64() | ||
| )) |
There was a problem hiding this comment.
Small suggestion here. Dig prints the TCPKEEPALIVE without "secs" if the value is missing. It also has a space between the two words.
; <<>> DiG 9.18.33 <<>> google.com A +tcp +keepalive +qr
;; global options: +cmd
;; Sending:
;; ->>HEADER<<- opcode: QUERY, status: NOERROR, id: 32748
;; flags: rd ad; QUERY: 1, ANSWER: 0, AUTHORITY: 0, ADDITIONAL: 1
;; OPT PSEUDOSECTION:
; EDNS: version: 0, flags:; udp: 1232
; COOKIE: 916ce5e901a627c4
; TCP KEEPALIVE:
;; QUESTION SECTION:
;google.com. IN A
...
src/output/dig.rs
Outdated
| @@ -46,7 +47,7 @@ pub fn write( | |||
| target, | |||
| "; EDNS: version {}; flags: {}; udp: {}", | |||
There was a problem hiding this comment.
I just noticed that dig does a , instead of a ; after the version
|
@Philip-NLnetLabs I can't request review because it's your PR, but it would be great if you could review these fixes. |
|
Those look good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started with 'do' instead of 'true'. But I also improved the question section and the value of the TCP Keepalive option.