Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verifier Refactor for Multi-tenant Configs #182

Merged
merged 5 commits into from
Jul 18, 2024
Merged

Conversation

nie7321
Copy link
Member

@nie7321 nie7321 commented Jul 17, 2024

Overview

This PR adds a new config item for the Azure Entra ID SSO, token_verifier. It should be northwestern, common, or a class that implements \Northwestern\SysDev\SOA\Auth\OAuth2\TokenVerifier\Contract\TokenVerifierInterface.

This is meant to be used in multi-tenant configurations; the package was always verifying the ID token was issued by the NU tenant, but for multi-tenant apps, the issuer will be their "home" tenant ID.

No changes need to be made for most use-cases; this still defaults to NU-only.

@nie7321 nie7321 requested review from cecolby11 and dxnter July 17, 2024 14:56
@coveralls
Copy link

Coverage Status

coverage: 45.277% (+0.6%) from 44.688%
when pulling 537a66c on verifier-refactor
into 262b589 on develop.

@nie7321 nie7321 requested review from bab4379 and mc0918 July 17, 2024 16:26
@nie7321 nie7321 merged commit 0c4b455 into develop Jul 18, 2024
4 checks passed
@nie7321 nie7321 deleted the verifier-refactor branch July 18, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants