Skip to content

added a message on library card onnullcontent #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2025

Conversation

simaopsbarbosa
Copy link
Contributor

@simaopsbarbosa simaopsbarbosa commented Apr 19, 2025

Closes #1559
added a message to the library card onNullContent instead of the loading circle

testing it

to force the widget to show ONC, temporarily change the hasContent to:
hasContent: (libraryOccupation) => false,

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@simaopsbarbosa simaopsbarbosa requested a review from DGoiana April 19, 2025 17:50
Copy link

codecov bot commented Apr 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 9%. Comparing base (df6be03) to head (dc198dd).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1576   +/-   ##
=======================================
- Coverage        9%      9%   -0%     
=======================================
  Files          261     261           
  Lines         7483    7488    +5     
=======================================
  Hits           650     650           
- Misses        6833    6838    +5     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@DGoiana
Copy link
Collaborator

DGoiana commented Apr 19, 2025

Can you add a screenshot of the final result? And can you maybe try to implement it with the new IconLabel? Just find an icon that you think it'll suit well.

@simaopsbarbosa simaopsbarbosa requested review from DGoiana, thePeras, pedroafmonteiro and peucastro and removed request for DGoiana April 19, 2025 20:18
@simaopsbarbosa simaopsbarbosa self-assigned this Apr 19, 2025
Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

Copy link
Member

@peucastro peucastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Just for consistency, please align the text style with the one used in the onNullContent implementation from this PR #1529

Copy link
Member

@peucastro peucastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀✅

@peucastro peucastro merged commit a4ba28c into develop Apr 19, 2025
6 checks passed
@peucastro peucastro deleted the fix/library-card-onnullcontent branch April 19, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change library card onNullContent
3 participants