-
Notifications
You must be signed in to change notification settings - Fork 18
added a message on library card onnullcontent #1576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1576 +/- ##
=======================================
- Coverage 9% 9% -0%
=======================================
Files 261 261
Lines 7483 7488 +5
=======================================
Hits 650 650
- Misses 6833 6838 +5 🚀 New features to boost your workflow:
|
Can you add a screenshot of the final result? And can you maybe try to implement it with the new |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀✅
Closes #1559
added a message to the library card onNullContent instead of the loading circle
testing it
to force the widget to show ONC, temporarily change the hasContent to:
hasContent: (libraryOccupation) => false,
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change