Skip to content

Fix: library card Unsupported operation: infinity or Nan to int #1574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 19, 2025

Conversation

peucastro
Copy link
Member

Closes #1535

Updated the hasContent condition in the LibraryHomeCard widget to ensure it only renders when the library occupation is initialized.

Screenshot

untitled.online-video-cutter.com.mp4

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@peucastro peucastro self-assigned this Apr 18, 2025
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 9%. Comparing base (381df75) to head (811d3b6).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1574   +/-   ##
=======================================
  Coverage        9%      9%           
=======================================
  Files          261     261           
  Lines         7487    7487           
=======================================
  Hits           650     650           
  Misses        6837    6837           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@peucastro peucastro requested a review from a team April 18, 2025 22:04
Copy link
Collaborator

@DGoiana DGoiana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!! 😄

@DGoiana DGoiana requested a review from a team April 19, 2025 12:08
Copy link
Member

@Adriano-7 Adriano-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Adriano-7 Adriano-7 merged commit 6b87cbb into develop Apr 19, 2025
6 checks passed
@Adriano-7 Adriano-7 deleted the fix/library-card-NaN branch April 19, 2025 12:18
@peucastro peucastro removed their assignment Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported operation: infinity or Nan to int at the Faculty Page
3 participants