Skip to content

fix: service card overflow #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

fix: service card overflow #1562

merged 3 commits into from
Apr 16, 2025

Conversation

simaopsbarbosa
Copy link
Contributor

@simaopsbarbosa simaopsbarbosa commented Apr 8, 2025

Closes #1538
Fixed the services cards aspect ratio issue by using Wrap instead of a grid. This makes it so that every ServiceCard uses only as much height space as it needs, which means that when a service has no lunch break (openingHours is only one time interval) it results in a smaller ServiceCard, which might look off in the 2 column view (see picture below). I think this is still a minor thing that is barely noticeable, especially when the smallest card is in the bottom, but lmk what you think.

Also fixed a small overflow bug on the openingHours text.

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@simaopsbarbosa simaopsbarbosa self-assigned this Apr 8, 2025
Copy link

codecov bot commented Apr 8, 2025

Codecov Report

Attention: Patch coverage is 0% with 37 lines in your changes missing coverage. Please review.

Project coverage is 9%. Comparing base (fd1154f) to head (6f85e56).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1562   +/-   ##
=======================================
- Coverage        9%      9%   -0%     
=======================================
  Files          259     259           
  Lines         7429    7438    +9     
=======================================
  Hits           650     650           
- Misses        6779    6788    +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@peucastro peucastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🔥

@DGoiana DGoiana merged commit fa48551 into develop Apr 16, 2025
6 checks passed
@DGoiana DGoiana deleted the fix/service-card-overflow branch April 16, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service card overflow
3 participants