-
Notifications
You must be signed in to change notification settings - Fork 18
Redesign/empty state home images #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
From a design perspective, I think the images here should be simpler |
Definetly simpler, and smaller |
Increase the size of the icon a bit and decrease the size of the text. Also use duotone. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done!! ✅ 🛫
Codecov ReportAttention: Patch coverage is
❌ Your project check has failed because the head coverage (9%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #1529 +/- ##
=======================================
- Coverage 9% 9% -0%
=======================================
Files 259 261 +2
Lines 7438 7477 +39
=======================================
Hits 650 650
- Misses 6788 6827 +39 🚀 New features to boost your workflow:
|
@@ -12,6 +12,9 @@ import 'package:uni/view/lazy_consumer.dart'; | |||
import 'package:uni/view/locale_notifier.dart'; | |||
import 'package:uni_ui/cards/exam_card.dart'; | |||
import 'package:uni_ui/cards/timeline_card.dart'; | |||
import 'package:uni_ui/icons.dart'; | |||
|
|||
import '../../../common_widgets/icon_label.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use absolute imports instead of relative ones
@@ -0,0 +1,40 @@ | |||
import 'package:flutter/material.dart'; | |||
|
|||
import '../../../../generated/l10n.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
import '../../../../generated/l10n.dart'; | ||
import '../../../common_widgets/icon_label.dart'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here!
…P/uni into redesign/empty-state-home-images
Closes #639
Review checklist
whatsnew/whatsnew-pt-PT
changelog.md
with the change