Skip to content

Redesign/empty state home images #1529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

jcovaa
Copy link
Contributor

@jcovaa jcovaa commented Mar 22, 2025

Closes #639

Review checklist

  • Terms and conditions reflect the current change
  • Contains enough appropriate tests
  • If aimed at production, writes a new summary in whatsnew/whatsnew-pt-PT
  • Properly adds an entry in changelog.md with the change
  • If PR includes UI updates/additions, its description has screenshots
  • Behavior is as expected
  • Clean, well-structured code

@jcovaa jcovaa changed the base branch from develop to ui/redesign March 22, 2025 13:01
@jcovaa
Copy link
Contributor Author

jcovaa commented Mar 22, 2025

I used imageLabel to build the widgets. They look like this:

@thePeras
Copy link
Member

From a design perspective, I think the images here should be simpler

@DGoiana
Copy link
Collaborator

DGoiana commented Mar 25, 2025

Definetly simpler, and smaller

@jcovaa
Copy link
Contributor Author

jcovaa commented Apr 1, 2025

@DGoiana
Copy link
Collaborator

DGoiana commented Apr 1, 2025

Increase the size of the icon a bit and decrease the size of the text. Also use duotone.
Make sure you make the button a squircle

@jcovaa
Copy link
Contributor Author

jcovaa commented Apr 1, 2025

The icons are like this:

@jcovaa jcovaa changed the base branch from ui/redesign to develop April 1, 2025 17:49
Copy link
Member

@thePeras thePeras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!! ✅ 🛫

Copy link

codecov bot commented Apr 6, 2025

Codecov Report

Attention: Patch coverage is 2.22222% with 44 lines in your changes missing coverage. Please review.

Project coverage is 9%. Comparing base (fa48551) to head (2c07150).
Report is 6 commits behind head on develop.

❌ Your project check has failed because the head coverage (9%) is below the target coverage (70%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##           develop   #1529   +/-   ##
=======================================
- Coverage        9%      9%   -0%     
=======================================
  Files          259     261    +2     
  Lines         7438    7477   +39     
=======================================
  Hits           650     650           
- Misses        6788    6827   +39     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jcovaa
Copy link
Contributor Author

jcovaa commented Apr 8, 2025

Add restaurants button is like this:

@@ -12,6 +12,9 @@ import 'package:uni/view/lazy_consumer.dart';
import 'package:uni/view/locale_notifier.dart';
import 'package:uni_ui/cards/exam_card.dart';
import 'package:uni_ui/cards/timeline_card.dart';
import 'package:uni_ui/icons.dart';

import '../../../common_widgets/icon_label.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use absolute imports instead of relative ones

@@ -0,0 +1,40 @@
import 'package:flutter/material.dart';

import '../../../../generated/l10n.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

Comment on lines 14 to 15
import '../../../../generated/l10n.dart';
import '../../../common_widgets/icon_label.dart';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Empty state illustrations for cards
3 participants