Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update spine-directory-service.yaml #248

Merged
merged 2 commits into from
Feb 6, 2024
Merged

Conversation

nkinsler1
Copy link
Contributor

Summary

  • Routine Change
  • ❗ Breaking Change
  • 🤖 Operational or Infrastructure Change
  • ✨ New Feature
  • ⚠️ Potential issues that might be caused by this change

Add any other relevant notes or explanations here. Remove this line if you have nothing to add.

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

Copy link

github-actions bot commented Nov 9, 2023

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

1 similar comment
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

github-actions bot commented Feb 2, 2024

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

APM-000

Copy link

github-actions bot commented Feb 5, 2024

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

APM-000

Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jameslinnell
Copy link
Contributor

jameslinnell commented Feb 5, 2024

Question asked on #platforms-apim-producer-support https://nhsdigital-platforms.slack.com/archives/C016JRWN6AY/p1707135394278509

James Linnell : Can anyone tell me if this email is still relevant? It's in an unmerged branch on spine directory service? [email protected] It's replacing this [email protected] . Just trying to prune out unnecessary branches from this repo. (edited)

Reply: Harry Coulter : Hi James, yes, external APIM support queries are now handled via the service desk rather than the [email protected] inbox

So this PR still seems relevant.

@nkinsler1 nkinsler1 merged commit 78272b2 into master Feb 6, 2024
7 checks passed
@jameslinnell jameslinnell deleted the APM-000-AMP-2214-fix-mailbox branch February 8, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants