Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NIAD-2181 #212

Open
wants to merge 53 commits into
base: master
Choose a base branch
from
Open

NIAD-2181 #212

wants to merge 53 commits into from

Conversation

ellenwootten
Copy link
Contributor

@ellenwootten ellenwootten commented Jun 28, 2022 •
edited
Loading

Co-Authored-By: abidmajid1 [email protected]

Ready for review!

Summary

  • ✨ New Feature
  • New PractitionRole endpoint which given an NHSD SESSION URID will return the relevant role code

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

29 similar comments
@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

github-actions bot commented Jul 8, 2022

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

@github-actions
Copy link

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

ellenwootten and others added 27 commits February 8, 2024 14:57
@ellenwootten @jameslinnell
update pipfile to be inline with dockerfile
3ab0e2f
@ellenwootten @jameslinnell
Delete smoketest-report.xml
fea6fa2
@ellenwootten @jameslinnell
Delete Pipfile
001b64e
@ellenwootten @jameslinnell
added back in pip lock
c4821db
@ellenwootten @jameslinnell
Update poetry.lock
58029a2
@abidmajid1 @jameslinnell
fixed json example + test
810843a
@ellenwootten @jameslinnell
check role is active
c47a381
@ellenwootten @jameslinnell
logging
5f1b88a
@ellenwootten @jameslinnell
nhsOrgOpenDate and appropriate conditional operator used
e6acabb
@ellenwootten @jameslinnell
building up query - base
096a45b
@ellenwootten @jameslinnell
open date search filter
44f860e
@ellenwootten @jameslinnell
Update sds_client.py
92f57fe
@ellenwootten @jameslinnell
is or the problem?
72d6dbc
@ellenwootten @jameslinnell
with not, no or
e287aa6
@ellenwootten @jameslinnell
is > only the problem?
41a021a
@ellenwootten @jameslinnell
full query
d785f62
@ellenwootten @jameslinnell
Update sds_client.py
46e0596
@ellenwootten @jameslinnell
no spaces?
b7eb5d5
@ellenwootten @jameslinnell
it was not the spaces, returning to when it last worked?
5ac6c64
@ellenwootten @jameslinnell
open date works... test close date on it's own
a5739a3
@ellenwootten @jameslinnell
try both dates, on their own
60eb0b3
@ellenwootten @jameslinnell
Update sds_client.py
ec272d6
@ellenwootten @jameslinnell
Update sds_client.py
cf80891
@ellenwootten @jameslinnell
Update sds_client.py
8be807a
@ellenwootten @jameslinnell
reorder, tidy code, comment
3598901
@ellenwootten @jameslinnell
Update .gitignore
8aeb826
@jameslinnell
Fix .gitignore
c40f920
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2024

This branch is work on a ticket in the NHS Digital APM JIRA Project. Here's a handy link to the ticket:

NIAD-2181

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellenwootten @jameslinnell @abidmajid1