Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add request parameters filename and fileSize #463

Open
wants to merge 6 commits into
base: feature/xapi-file-upload
Choose a base branch
from
Open

Add request parameters filename and fileSize #463

wants to merge 6 commits into from

Conversation

francisco-videira-nhs
Copy link
Contributor

Summary

  • Routine Change

Reviews Required

  • Dev
  • Test
  • Tech Author
  • Product Owner

Review Checklist

ℹ️ This section is to be filled in by the reviewer.

  • I have reviewed the changes in this PR and they fill all or part of the acceptance criteria of the ticket, and the code is in a mergeable state.
  • If there were infrastructure, operational, or build changes, I have made sure there is sufficient evidence that the changes will work.
  • I have ensured the changelog has been updated by the submitter, if necessary.

nhsd-jack-wainwright
nhsd-jack-wainwright reviewed Sep 28, 2022
View reviewed changes
Copy link
Contributor

@nhsd-jack-wainwright nhsd-jack-wainwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just a couple minor comments.

sandbox/src/routes/r4/services/mockResponseProvider.js Outdated Show resolved Hide resolved
specification/components/r4/schemas/eRS-GenerateUploadUri-Request-Parameters.yaml Outdated Show resolved Hide resolved
@strutt strutt added the dependencies Pull requests that update a dependency file label Oct 28, 2022
@francisco-videira-nhs francisco-videira-nhs force-pushed the feature/xapi-file-upload branch 2 times, most recently from d5ed455 to cfee633 Compare February 24, 2023 13:16
@nhsd-angel-pastor nhsd-angel-pastor requested a review from a team as a code owner June 14, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhsd-jack-wainwright nhsd-jack-wainwright nhsd-jack-wainwright left review comments

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@francisco-videira-nhs @nhsd-jack-wainwright @strutt