[ERSSUP-80437]-[]-[Add new attachment attributes to STU3 endpoints]-[SB] #1880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevebux
requested review from
nhsd-david-wass,
adamoldfield-nhs,
nhsd-jack-wainwright and
a team
as code owners
stevebux
force-pushed
the
feature/ERSSUP-80437
branch
from
27de78e
to
aeb9bdf
Compare
| enum: | ||
| - 'https://fhir.nhs.uk/STU3/CodeSystem/eRS-AvailabilityStatus-1' | ||
| example: 'https://fhir.nhs.uk/STU3/CodeSystem/eRS-AvailabilityStatus-1' | ||
| code: |
There was a problem hiding this comment.
this might need to be valueCoding instead?
| url: | ||
| type: string | ||
| enum: | ||
| - 'https://fhir.nhs.uk/STU3/StructureDefinition/Extension-eRS-AttachedBy-Organisation-1' |
There was a problem hiding this comment.
implemented as per story, it might be worth confirming the - between By and Organisation
stevebux
commented
Nov 19, 2024
| @@ -115,23 +115,10 @@ properties: | |||
| extension: | |||
| type: array | |||
| minItems: 1 | |||
| maxItems: 1 | |||
| maxItems: 4 | |||
| items: | |||
| "identifier": { | ||
| "system": "http://fhir.nhs.net/Id/sds-user-id", | ||
| "value": "021600556514" | ||
| } |
There was a problem hiding this comment.
Should be different from attached by
| "payload": [ | ||
| { | ||
| "contentReference": { | ||
| "reference": "DocumentReference/70001" |
stevebux
force-pushed
the
feature/ERSSUP-80437
branch
from
aeb9bdf
to
71ce383
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add any other relevant notes or explanations here. Remove this line if you have nothing to add.
Reviews Required
Review Checklist
ℹ️ This section is to be filled in by the reviewer.