Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dtoss 6235 create terraform module for azure event grid #87

Merged

Conversation

mrlockstar
Copy link
Contributor

@mrlockstar mrlockstar commented Dec 20, 2024

Description

Given* that I have access to the necessary Terraform and Azure resources,
When I create the Terraform module for Azure Event Grid,
Then the module should configure the Event Grid to be compliant with UK OFFICIAL standards,
And the module should ensure compliance with UK NHS policies,
And the module should adhere to the Azure Security Benchmark policies,
Or provide documentation for any deviations or exceptions.
Given that the module is deployed,
When the Azure Event Grid is provisioned,
Then it should pass all relevant compliance checks for UK OFFICIAL, UK NHS, and Azure Security Benchmark policies.
Given that there are updates to the policies,
When the module is reviewed,
Then it should be updated to maintain compliance with the latest UK OFFICIAL, UK NHS, and Azure Security Benchmark policies.

https://dev.azure.com/nhse-dtos/dtos-service-insights/_build/results?buildId=11419&view=results

Context

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@mrlockstar mrlockstar force-pushed the feat/DTOSS-6235-Create-Terraform-Module-for-Azure-Event-Grid branch from b79ba4f to 51b138b Compare December 20, 2024 11:44
@mrlockstar mrlockstar force-pushed the feat/DTOSS-6235-Create-Terraform-Module-for-Azure-Event-Grid branch from 51b138b to 6e2d803 Compare December 20, 2024 11:46
@mrlockstar mrlockstar marked this pull request as ready for review December 20, 2024 12:18
Copy link
Collaborator

@MacMur85 MacMur85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@mrlockstar mrlockstar added this pull request to the merge queue Dec 20, 2024
Merged via the queue into main with commit 2ffdeb8 Dec 20, 2024
23 checks passed
@mrlockstar mrlockstar deleted the feat/DTOSS-6235-Create-Terraform-Module-for-Azure-Event-Grid branch December 20, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants