Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DNS zone changes in hub #64

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrickmoore-nc
Copy link
Contributor

@patrickmoore-nc patrickmoore-nc commented Nov 26, 2024

Description

  • Amendments to private DNS zone resource keying following code changes to dtos-hub, and the move from dev. to non-live.nationalscreening.nhs.uk.
  • Diagnostic logging to the Log Analytics Workspace in Audit subscription.

Deployed successfully to:

Type of changes

  • Refactoring (non-breaking change)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would change existing functionality)
  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • I am familiar with the contributing guidelines
  • I have followed the code style of the project
  • I have added tests to cover my changes
  • I have updated the documentation accordingly
  • This PR is a result of pair or mob programming

Sensitive Information Declaration

To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.

  • I confirm that neither PII/PID nor sensitive data are included in this PR and the codebase changes.

@patrickmoore-nc patrickmoore-nc force-pushed the fix/dns-zone-changes-in-hub branch 2 times, most recently from eabc130 to 7b7f954 Compare November 26, 2024 17:11
@patrickmoore-nc patrickmoore-nc marked this pull request as ready for review November 26, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants