Integrate db migrations #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We all love a bar chart
Uses HMAC signature validation to verify expected headers with a request body. The actual implementation is abstracted from requests themselves so we deal with strings, dictionaries and booleans as inputs and outputs.
Flask titlecases the keys in Headers, make sure we lowercase before attempting access.
Use the OAS file provided by NHS Notify to validate the incoming POST body.
Make healthcheck a top level endpoint, it should not be nested in the sttaus/ route.
Co-authored-by: Nimmo <[email protected]>
Add status endpoint to API
When the status callback endpoint receives requests the post body will be saved to the database to record the channel and message status depending on the payload type. This commit adds the datastore and service module which handles this persistence.
There's good support for composition of SQL in psycopg2 so use it.
We do this in test setup quite a few times so make it a utility.
We now have local dev and test dbs so improve tests by asserting persistence has worked as expected.
Persist status callback requests
WIP - [DTOSS-6505] DB migrations
We will be sending messages using NHS Notify's message batch endpoint, this means a revision of how we store incoming data and the success of the requests to Notify. We will be archiving existing data from the pilot, likely by renaming the existing tables so it is fine to start the migration revisions with the intended schema.
This was a temporary measure and a good thing that we are removing it to replace with database migrations.
|
Closing wrong base branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.