Persist status callback requests #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the status callback endpoint receives requests the post body will be saved to the database to record the channel and message status depending on the payload type. This commit adds the datastore and service module which handles this persistence.
There's good support for composition of SQL in psycopg2 so use it.
We do this in test setup quite a few times so make it a utility.
steventux
force-pushed
the
persist-status-callback-requests
branch
9 times, most recently
from
6a42144 to
21fb910
Compare
steventux
force-pushed
the
persist-status-callback-requests
branch
from
21fb910 to
ec5d825
Compare
dnimmo
approved these changes
Jan 17, 2025
We now have local dev and test dbs so improve tests by asserting persistence has worked as expected.
steventux
force-pushed
the
persist-status-callback-requests
branch
from
79020fd to
97472a4
Compare
dnimmo
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Context
When NHS Notify sends callback data via the status endpoint
POST /api/status/createwe need to persist the data in the post body. This helps us to understand the delivery success of notifications we have sent.Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.