Record channel status callbacks #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
force-pushed
the
record-channel-status-callbacks
branch
4 times, most recently
from
5e88b2f to
f7da73e
Compare
Too many concerns in the datastore module. Extract schema initialisation, we may eventually turn this into a migration module.
steventux
force-pushed
the
record-channel-status-callbacks
branch
from
f7da73e to
9491eed
Compare
We can save message status data or channel status data, these are stored in separate tables but essentially in the same format.
steventux
force-pushed
the
record-channel-status-callbacks
branch
from
9491eed to
a1c7ac9
Compare
This can validate incoming channel and message status data.
Handle saving both channel and message status data.
steventux
force-pushed
the
record-channel-status-callbacks
branch
from
a1c7ac9 to
40cc3f7
Compare
steventux
added a commit
that referenced
this pull request
Dec 30, 2024
This reverts commit 32c8390.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Record channel status callback data in a separate database table.
Context
After running the initial batch of notifications we needed to understand success and failure metrics from the saved data.
ChannelStatus callbacks contain a finer grained level of data which helps with understanding how a recipient has or has not been notified.
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.