Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncated distributions for Damage Model. #89

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ioannis-vm
Copy link
Contributor

The requested feature is already implemented.
This PR adds a test case.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.51%. Comparing base (8af9462) to head (85cc691).
Report is 493 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #89       +/-   ##
===========================================
- Coverage   92.52%   81.51%   -11.02%     
===========================================
  Files          12       17        +5     
  Lines        2516     4841     +2325     
===========================================
+ Hits         2328     3946     +1618     
- Misses        188      895      +707     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@zsarnoczay zsarnoczay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test. There's a file I'm not sure we need, please confirm. Otherwise, ready to merge.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this file really needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out. That file shouldn't have been committed.

Adds damage model test case with tuncation limits.
@ioannis-vm ioannis-vm force-pushed the 2024-12_truncated_distr branch from 85cc691 to 4534989 Compare December 22, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants