radiation refactors - rad_error and rad profile diagnostics

[rgknox]

Description:

This set of changes addresses isues brought up by @mvdebolskiy related to coupling radiation with FATES and CAM: #1376 (comment) . This led to a generalized refactor of radiation diagnostics, particularly radiation profiles, and how these things are initialized and written to output given the nature of the normalized radiation calls (ie that the current day's albedo is calculated at the end of the previous timestep).

This PR has a sibling PR in NorESMhub: https://github.com/NorESMhub/fates/pull/17/files

Collaborators:

@mvdebolskiy

Expectation of Answer Changes:

yes, this will change fates radiation history variables (high frequency multi-layer canopy output), but those only. This is because more attention is being paid to when they are zero'd and when they are ignored.

Checklist

If this is your first time contributing, please read the CONTRIBUTING document.

All checklist items must be checked to enable merging this pull request:

Contributor

• The in-code documentation has been updated with descriptive comments
• The documentation has been assessed to determine if updates are necessary

Integrator

• FATES PASS/FAIL regression tests were run
• Evaluation of test results for answer changes was performed and results provided
• FATES-CLM6 Code Freeze: satellite phenology regression tests are b4b

If satellite phenology regressions are not b4b, please hold merge and notify the FATES development team.

Documentation

• Technical Note update:
• User's Guide update:

Test Results:

CTSM (or) E3SM (specify which) test hash-tag:

CTSM (or) E3SM (specify which) baseline hash-tag:

FATES baseline hash-tag:

Test Output:

[rgknox]

See comment: ESCOMP/CTSM#3051 (comment)

cc @mvdebolskiy

[glemieux]

This looks good. I really like how the downstream calculations for the diagnostics are now conducted in the history interface module. I like the practice of adjusting the output in this module, rather than in the calculating module.

[rgknox]

All tests ok on Derecho, compared against base: fates-sci.1.87.3_api.41.0.0-ctsm5.3.077

Some expected diffs with base, but relegated to only the variables that were changed (rad_error and some of the multiplexed rad diagnostics).

Also, I was hoping that this test would start passing, and it does!

PASS ERI_D_Ld9.f45_f45_mg37.I2000Clm60FatesSpCruRsGs.derecho_gnu.clm-FatesColdSatPhenCamLndTuningMode COMPARE_base_rest (UNEXPECTED: expected FAIL)