Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-view): nzTreeNodePadding not works in virtual scroll #8920

Merged

Conversation

WwwHhhYran
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #8915

What is the new behavior?

nzTreeNodePadding works in virtual scroll

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@WwwHhhYran WwwHhhYran requested a review from hsuanxyz as a code owner December 11, 2024 06:13
Copy link

zorro-bot bot commented Dec 11, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.93%. Comparing base (2e0c78d) to head (8566286).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8920      +/-   ##
==========================================
+ Coverage   91.91%   91.93%   +0.01%     
==========================================
  Files         554      554              
  Lines       19682    19682              
  Branches     2936     2936              
==========================================
+ Hits        18091    18094       +3     
+ Misses       1265     1263       -2     
+ Partials      326      325       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WwwHhhYran
Copy link
Contributor Author

Although this pull request is abled to solve the issue (nzTreeNodePadding not working #8915 ) temporarily, @angular/cdk revamped CdkTree in version 18.2.0:

  • deprecate treeControl (which might be removed in a future version)
  • add levelAccessor, childrenAccessor instead.

while the nzTreeView of Ng Zorro extends CdkTree and requires the input [nzTreeControl] which depends on the soon-to-be-deprecated treeControl. Therefore, I plan to refactor this part in the future 🚀.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Laffery Laffery merged commit 82b660a into NG-ZORRO:master Dec 14, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeView: nzTreeNodePadding not works in virtual scroll
2 participants