Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:auto-complete): click input field can not popup option panel when it was focused #8900

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WwwHhhYran
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

like the video below:

step1: click the input field and then click one option (e.g. Lucy)
step2: option panel will close after click, then we still click the input field, no response.

ps: In step2, if we re-click input field of the auto-complete component of Ant Design, the option panel will pop up.

2024-11-28.20.56.26.mov

What is the new behavior?

solved the above issue: if we re-click the input field which has been focused, the option panel still able to pop up

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@WwwHhhYran WwwHhhYran requested a review from hsuanxyz as a code owner November 28, 2024 13:12
Copy link

zorro-bot bot commented Nov 28, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (c3ab3ba) to head (f6e7368).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8900      +/-   ##
==========================================
- Coverage   91.84%   91.82%   -0.02%     
==========================================
  Files         548      548              
  Lines       19305    19308       +3     
  Branches     2862     2863       +1     
==========================================
  Hits        17730    17730              
- Misses       1260     1262       +2     
- Partials      315      316       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants