Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): fix disabled date range boundary bug #8892

Conversation

WwwHhhYran
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: close #8805

What is the new behavior?

support to pick the end date of the accessaible date range

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@WwwHhhYran WwwHhhYran requested a review from wenqi73 as a code owner November 23, 2024 05:16
Copy link

zorro-bot bot commented Nov 23, 2024

This preview will be available after the AzureCI is passed.

Copy link

codecov bot commented Nov 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.89%. Comparing base (0202a19) to head (61cd08c).
Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8892   +/-   ##
=======================================
  Coverage   91.89%   91.89%           
=======================================
  Files         546      546           
  Lines       19291    19291           
  Branches     2850     2851    +1     
=======================================
  Hits        17728    17728           
  Misses       1251     1251           
  Partials      312      312           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Laffery Laffery changed the title fix(module:datePicker): fix disabled date range boundary bug fix(module:date-picker): fix disabled date range boundary bug Nov 23, 2024
@Laffery
Copy link
Collaborator

Laffery commented Dec 28, 2024

close because the original question was just a usage issue

@Laffery Laffery closed this Dec 28, 2024
@WwwHhhYran
Copy link
Contributor Author

WwwHhhYran commented Dec 29, 2024

close because the original question was just a usage issue

@Laffery Although it is possible to solve the problem in the issue with a specific usage, in AntD it is possible to select the last date if we set the ‘disabledDate’, but not in ng zorro, so I think this is also a flaw in ng zorro ?

e.g. https://codesandbox.io/p/sandbox/datepicker-mh5r76

ps: AntD date based on dayjs info

@Laffery
Copy link
Collaborator

Laffery commented Jan 1, 2025

Although it is possible to solve the problem in the issue with a specific usage, in AntD it is possible to select the last date if we set the ‘disabledDate’, but not in ng zorro, so I think this is also a flaw in ng zorro ?

As I can see, ng zorro supports that as well
https://stackblitz.com/edit/angular-taetoz-exnyqh?file=src%2Fapp%2Fapp.component.ts

antd:
image

ng-zorro-antd:
image

@WwwHhhYran
Copy link
Contributor Author

As I can see, ng zorro supports that as well https://stackblitz.com/edit/angular-taetoz-exnyqh?file=src%2Fapp%2Fapp.component.ts

In the demo of ng zorro above, if you don't use the date-fns library, it won't be able to automatically close the dropdown data-picker when clicking on date 2025-1-31 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants