Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:cdkconnectedoverlay): supports disabling click on mask #8878

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OriginRing
Copy link
Collaborator

@OriginRing OriginRing commented Nov 13, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Application (the showcase website) / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link

zorro-bot bot commented Nov 13, 2024

This preview will be available after the AzureCI is passed.

@OriginRing OriginRing force-pushed the feat/cdkConnectedOverlay branch from d55ccf5 to 372756c Compare November 13, 2024 09:56
@OriginRing OriginRing requested a review from Laffery November 13, 2024 09:56
@OriginRing OriginRing force-pushed the feat/cdkConnectedOverlay branch from 372756c to 90214cb Compare November 13, 2024 10:40
Copy link

codecov bot commented Nov 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.91%. Comparing base (2e0c78d) to head (a1a6c2a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8878   +/-   ##
=======================================
  Coverage   91.91%   91.91%           
=======================================
  Files         554      554           
  Lines       19682    19688    +6     
  Branches     2936     2938    +2     
=======================================
+ Hits        18091    18097    +6     
  Misses       1265     1265           
  Partials      326      326           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Laffery Laffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 comments, and please add unit tests

components/tooltip/base.ts Outdated Show resolved Hide resolved
@Laffery Laffery added PR: reviewed-changes-requested PR: need-test Test is necessary for code changes. and removed PR: unreviewed labels Nov 14, 2024
@OriginRing OriginRing force-pushed the feat/cdkConnectedOverlay branch 3 times, most recently from 5774cbc to 21cd1c9 Compare November 19, 2024 03:07
@OriginRing OriginRing force-pushed the feat/cdkConnectedOverlay branch 2 times, most recently from a1e5e21 to 0ca53d8 Compare November 21, 2024 01:56
@OriginRing OriginRing force-pushed the feat/cdkConnectedOverlay branch from 0ca53d8 to c07252b Compare November 22, 2024 10:27
@HyperLife1119 HyperLife1119 added PR: need-rebase and removed PR: need-test Test is necessary for code changes. labels Dec 4, 2024
@OriginRing OriginRing force-pushed the feat/cdkConnectedOverlay branch from c07252b to bfdd018 Compare December 10, 2024 02:33
@OriginRing OriginRing force-pushed the feat/cdkConnectedOverlay branch from bfdd018 to a1a6c2a Compare December 11, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants