-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:table): updated the condition for displaying nz-pagination… #8628
base: master
Are you sure you want to change the base?
Conversation
… when nzTotal > 0
This preview will be available after the AzureCI is passed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8628 +/- ##
=======================================
Coverage 91.50% 91.50%
=======================================
Files 534 534
Lines 18425 18425
Branches 2905 2905
=======================================
Hits 16860 16860
Misses 1244 1244
Partials 321 321 ☔ View full report in Codecov by Sentry. |
Why do you need to show pagination when there is no data? 🤔 |
Hi, my friend. We currently have an issue with pagination: if the user is on page 2 and the backend returns empty data, but the total number of records (nzTotal) is greater than zero, the pagination disappears. As a result, the user cannot navigate back to the first page where data might be present. To work around this issue, the user has to clear the table filters to unlock the pagination. This enhancement is needed so that the user can manage pagination and return to the first page if there is no data on the current page. I have sent a video file to your email ([email protected]) where you can see exactly what this issue looks like. |
LGTM |
Ignore it, 'cause no npm dependency update. |
Please add enough unit tests for this feature :) |
… when nzTotal > 0
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
In order to hide the nz-pagination, one more condition is not taken into account: when nzTotal > 0
Issue Number: N/A
What is the new behavior?
now nz-pagination will be displayed when nzTotal > 0
Does this PR introduce a breaking change?
Other information