fix(module:icon): debounce icon rendering on animation frame #8579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturovt
changed the title
|
This preview will be available after the AzureCI is passed. |
arturovt
force-pushed
the
fix/7825
branch
2 times, most recently
from
d93128a to
6bb1b28
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8579 +/- ##
==========================================
- Coverage 91.95% 91.94% -0.01%
==========================================
Files 537 537
Lines 18452 18454 +2
Branches 2814 2815 +1
==========================================
+ Hits 16967 16968 +1
Misses 1183 1183
- Partials 302 303 +1 ☔ View full report in Codecov by Sentry. |
HyperLife1119
requested changes
Dec 5, 2024
| @@ -71,7 +75,9 @@ export class NzIconDirective extends IconDirective implements OnInit, OnChanges, | |||
| private iconfont?: string; | |||
| private spin: boolean = false; | |||
|
|
|||
| private destroy$ = new Subject<void>(); | |||
| private destroyRef = inject(DestroyRef); | |||
| private pendingTasks = inject(ExperimentalPendingTasks); | |||
There was a problem hiding this comment.
Suggested change
| private pendingTasks = inject(ExperimentalPendingTasks); | |
| private pendingTasks = inject(PendingTasks); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7825