-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:spin): now supports fullscreen #8183
base: master
Are you sure you want to change the base?
feat(module:spin): now supports fullscreen #8183
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8183 +/- ##
==========================================
+ Coverage 91.70% 91.72% +0.01%
==========================================
Files 519 519
Lines 17885 17888 +3
Branches 2747 2836 +89
==========================================
+ Hits 16401 16407 +6
+ Misses 1182 1180 -2
+ Partials 302 301 -1 ☔ View full report in Codecov by Sentry. |
components/spin/style/index.less
Outdated
z-index: 1000; | ||
max-height: unset; | ||
|
||
.ant-spin-dot-item { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.@{spin-prefix-cls}-item
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to .@{spin-prefix-cls}-dot-item
This feature involves several design tokens, and we may need more work to support it. These design tokens may also affect our style synchronization work. WDYT? @simplejason @OriginRing |
I am not clear about what you mean by design tokens. Do you mean the style changes that make the spin component white? How does this affect the feature and the style synchronization work? Can we use the current design tokens until we support the new ones? |
Hey folks! Now that v19 landed, could this be considered again? Having a full-screen backdrop blocking UI interactions would remove the need for additional logic and thus clean up code. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The spin component in our current version does not have the fullscreen mode feature that antd provides.
Issue Number: N/A
What is the new behavior?
The spin component has a new input property called
nzFullscreen
, which enables the display of a backdrop with the spin component when set totrue
.Does this PR introduce a breaking change?
Other information