-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: gulp file read endless waiting #7826
base: master
Are you sure you want to change the base?
fix: gulp file read endless waiting #7826
Conversation
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7826 +/- ##
==========================================
+ Coverage 92.08% 92.09% +0.01%
==========================================
Files 502 502
Lines 16819 16819
Branches 2577 2662 +85
==========================================
+ Hits 15487 15489 +2
+ Misses 1061 1060 -1
+ Partials 271 270 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better: replace console's "build-config.js" to ${BUILD_CONFIG_FILENAME}
Could you please a reproduction? What's the problem this PR supposed to solve? |
Yes: This is just a corner problem I encountered when learning this framework, I forget set build-config.js. |
Complete this pull request: support judging the root directory of different system environments.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
If build-config.js does not exist, the gulp command will cause endless waiting
What is the new behavior?
When the search reaches the end of the file system and still does not find the target file, then throw an error
Does this PR introduce a breaking change?
Other information