-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(module:space): nzSpaceItem margin in rtl #7801
base: master
Are you sure you want to change the base?
fix(module:space): nzSpaceItem margin in rtl #7801
Conversation
- Change 'margin-right' to 'margin-inline-end' and 'margin-bottom' to 'margin-block-end' for support any direction
This preview will be available after the AzureCI is passed. |
Codecov Report
@@ Coverage Diff @@
## master #7801 +/- ##
=======================================
Coverage 92.08% 92.08%
=======================================
Files 502 502
Lines 16782 16782
Branches 2562 2562
=======================================
Hits 15454 15454
+ Misses 1059 1056 -3
- Partials 269 272 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
I find |
What is the lowest version it should be? |
I think having proper localization (which includes RTL design) is more important than supporting old browsers anyways. |
Nearly two years on, we can look at the latest figures on caniuse, both I think it's time for us to import them in ng-zorro, WDYT? @lppedd |
'margin-bottom' to 'margin-block-end' for support any direction