Skip to content

Conversation

@Sundraiz-Shah
Copy link
Collaborator

No description provided.

@Sundraiz-Shah Sundraiz-Shah changed the title Related person table validation and improving ux WIP: Related person table validation and improving UX Oct 23, 2025
@Sundraiz-Shah
Copy link
Collaborator Author

Sundraiz-Shah commented Nov 4, 2025

In this PR following issues are solve

In this current PR merge table rows feature introduce. Merging feature executes when extracting data from hermes. User also have ability to merge row when given name and family name of the row similar. Other issues rrelated to table has also been address, for instance, validation on add button, alingment of the table, toast notification, Sticky header.

@Aidajafarbigloo
Copy link
Collaborator

Aidajafarbigloo commented Nov 6, 2025

@Sundraiz-Shah Thanks for the updates! After testing, I found the following issues:

  1. No feedback for invalid input:
    • When entering text not in the list (for Licenses or Programming Languages), there’s no feedback.
    • For Keywords, entering a duplicate value should trigger a notification informing the user that the keyword already exists.
  2. Layout and responsiveness issues:
    • When resizing or zooming the browser window, layout problems occur.
    • At higher zoom levels, some items and borders overlap or disappear. The bottom border is sometimes missing, and responsiveness is inconsistent across screen sizes.
  3. JSON download issue:
    • The download function for the JSON file doesn’t work properly.
  4. Invalid JSON output:
    • "null": "" entries are being added to the Contributor, Author, and Maintainer objects.
  5. Missing delete confirmation:
    • There’s no confirmation prompt when deleting rows from the Copyright Holder table.
  6. Email placeholder:
    • Please update the placeholder text for the Email field in the Persons tab.
  7. Merging issue:
    • When merging multiple rows, roles are not merged correctly. For example, if Contributor, Author, and Maintainer are all selected for a person in different rows, only Contributor appears in the merged row.
  8. Duplicate person validation in Persons tab:
    • When adding a new person, if another entry with the same Given Name and Family Name already exists, the new row should not be added. And a notification should appear to inform the user that the person already exists in the table.
  9. Duplicate copyright holder validation:
    • When adding a new Copyright Holder, if a record with the same Legal Name already exists, a notification should be presented to user and prevent adding duplicate entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants