[Performance] Add check to speed up function

NEZNAMY · Sep 13, 2024 · 225f30a · 225f30a
1 parent ae03436
commit 225f30a
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/shared/src/main/java/me/neznamy/tab/shared/Property.java b/shared/src/main/java/me/neznamy/tab/shared/Property.java
@@ -50,6 +50,9 @@ public class Property {
 
     /** Last known value after parsing non-relational placeholders */
     private String lastReplacedValue;
+
+    /** Flag tracking whether last replaced value may contain relational placeholders or not */
+    private boolean mayContainRelPlaceholders;
 
     /** Source defining value of the text, displayed in debug command */
     @Nullable private String source;
@@ -272,6 +275,7 @@ public boolean update() {
         string = EnumChatFormat.color(string);
         if (!lastReplacedValue.equals(string)) {
             lastReplacedValue = string;
+            mayContainRelPlaceholders = lastReplacedValue.indexOf('%') != -1;
             if (name != null) {
                 TAB.getInstance().getPlaceholderManager().getTabExpansion().setPropertyValue(owner, name, lastReplacedValue);
             }
@@ -297,6 +301,7 @@ public boolean update() {
      * @return  format for the viewer
      */
     public @NotNull String getFormat(@NotNull TabPlayer viewer) {
+        if (!mayContainRelPlaceholders) return lastReplacedValue;
         String format = lastReplacedValue;
         // Direct placeholders
         for (String identifier : relPlaceholders) {