Dev202505 #83
Merged
Dev202505 #83
+42
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… be converted correctly
…d be described as string.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for a new Refnum datatype (UserDefinedRefnumTag) and updates test case naming, documentation, and project configuration accordingly.
- Updated README and README(CN) to reflect the new Refnum(IVI/VISA/UserDefinedRefnumTag) datatype.
- Reordered and renamed test VIs in the LabVIEW class file for consistency.
- Updated package settings in vipb and lvproj files along with adding a new VI item in the library.
Reviewed Changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| testcase-Supported-Datatype.lvclass | Renamed/reordered test VI items; updated binary properties for FlattenedPrivateDataCTL. |
| README.md | Updated datatype reference in description for new UserDefinedRefnumTag. |
| README(CN).md | Updated the Chinese documentation to match datatype changes. |
| CSM API String Arguments Support.vipb | Updated version, modified date, release notes, and removed a global install flag. |
| CSM API String Arguments Support.lvproj | Added README(CN).md to project items. |
| API String Arguments Support.lvlib | Added a new VI for Cluster API String Mode. |
Comments suppressed due to low confidence (2)
testcases/testcase-Supported-Datatype/testcase-Supported-Datatype.lvclass:103
- [nitpick] The renaming and reordering of test VI items appears confusing. Please verify that the new test case names (e.g. 'test - Cluster2.vi' and the swapped items later) correctly reflect their intended functionality.
<Item Name="test - Cluster2.vi" Type="VI" URL="../testcases/test - Cluster2.vi">
CSM API String Arguments Support.vipb:257
- The removal of the 'install_into_global_environment' property might affect the package's global installation behavior. Confirm that this change is intentional and that any downstream effects are addressed.
<install_into_global_environment>false</install_into_global_environment>
added 4 commits
May 16, 2025 16:06
github-project-automation
bot
moved this from Linked to PR
to Done
in Communicable State Machine(CSM)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.