Skip to content

Dev202505 #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 29, 2025
Merged

Dev202505 #83

merged 7 commits into from
May 29, 2025

Conversation

nevstop
Copy link
Contributor

@nevstop nevstop commented May 8, 2025

No description provided.

nevstop added 3 commits May 6, 2025 21:43
… be converted correctly
…d be described as string.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for a new Refnum datatype (UserDefinedRefnumTag) and updates test case naming, documentation, and project configuration accordingly.

  • Updated README and README(CN) to reflect the new Refnum(IVI/VISA/UserDefinedRefnumTag) datatype.
  • Reordered and renamed test VIs in the LabVIEW class file for consistency.
  • Updated package settings in vipb and lvproj files along with adding a new VI item in the library.

Reviewed Changes

Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.

Show a summary per file
File Description
testcase-Supported-Datatype.lvclass Renamed/reordered test VI items; updated binary properties for FlattenedPrivateDataCTL.
README.md Updated datatype reference in description for new UserDefinedRefnumTag.
README(CN).md Updated the Chinese documentation to match datatype changes.
CSM API String Arguments Support.vipb Updated version, modified date, release notes, and removed a global install flag.
CSM API String Arguments Support.lvproj Added README(CN).md to project items.
API String Arguments Support.lvlib Added a new VI for Cluster API String Mode.
Comments suppressed due to low confidence (2)

testcases/testcase-Supported-Datatype/testcase-Supported-Datatype.lvclass:103

  • [nitpick] The renaming and reordering of test VI items appears confusing. Please verify that the new test case names (e.g. 'test - Cluster2.vi' and the swapped items later) correctly reflect their intended functionality.
<Item Name="test - Cluster2.vi" Type="VI" URL="../testcases/test - Cluster2.vi">

CSM API String Arguments Support.vipb:257

  • The removal of the 'install_into_global_environment' property might affect the package's global installation behavior. Confirm that this change is intentional and that any downstream effects are addressed.
<install_into_global_environment>false</install_into_global_environment>

NEVSTOP added 4 commits May 16, 2025 16:06
…-LAB" will have more chance be correctly parsed.
…ected Datatype)" thanks @wulei
@nevstop nevstop self-assigned this May 29, 2025
@nevstop nevstop marked this pull request as ready for review May 29, 2025 10:18
@nevstop nevstop merged commit aac6dca into main May 29, 2025
3 checks passed
@nevstop nevstop deleted the Dev202505 branch May 29, 2025 10:18
@github-project-automation github-project-automation bot moved this from Linked to PR to Done in Communicable State Machine(CSM) May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

None yet

1 participant