Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch processing #713

Merged
merged 5 commits into from
Jul 30, 2024
Merged

Batch processing #713

merged 5 commits into from
Jul 30, 2024

Conversation

jhennies
Copy link
Collaborator

  • Removed opening one of the result images in napari
  • Added generation of MoBIE table in order to view the results in MoBIE

@jhennies
Copy link
Collaborator Author

ping @tischi
I've nicened up the comments.

Shall we add that you can open the result in MoBIE here, for example as final bullet point in the list? Currently MoBIE is not mentioned at all...

@jhennies
Copy link
Collaborator Author

What's up with the failed tests, they have nothing to do with the batch processing module, right? Or did I break anything in this branch?

@tischi
Copy link
Collaborator

tischi commented Jul 30, 2024

Or did I break anything in this branch?

Not your fault, some python scripts don't run through. We can ignore this now and fix them later...


While it looks nice we should remove this code block because this is python specific. The activity preface must be general. You could add some pseudo code instead.

image

Shall we add that you can open the result in MoBIE

Again, we should not put anything specific in the activity preface, leaving teachers the option to show whatever implemenation they like best. We could add a sentence like: "Inspect the analysis results in a suitable software".

In fact, probably the exact same table could be opened with the Image Data Explorer.

We could add a link to MoBIE and the Image Data Explorer into the module.md:

learn_next:

external_links:
  - "[Batch processing in ImageJ](https://imagej.net/scripting/batch)"
  - MoBIE...
  - ImageDataExplorer ...

@jhennies
Copy link
Collaborator Author

Better? I also added mobie and imageDataExplorer to the external links. Hope I got the correct links

@tischi
Copy link
Collaborator

tischi commented Jul 30, 2024

Great! Let's merge it now! We can fine tune then directly on master.

@tischi tischi merged commit a751677 into master Jul 30, 2024
2 of 5 checks passed
@tischi tischi deleted the batch_processing branch July 30, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants