simplify filter_variance_skimage_napari.py #673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to reproduce our code in filter_variance_skimage_napari.py but failed.
Something was wrong with the computation of the variance image, it looked always very noisy and thus I could not threshold it successfully.
I changed this now.
Even though it introduces the concept of a function I find it much more readable, robust and useful than the previous approach, where a lot of code and mental load went into how to compute a variance; and, in fact, it did not work, for me.
I would have no worries that the students would understand this, because the function is super simple; and it actually very nicely fits the concept map of that you do some local math in a region of the image.