Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify and improve the all modules pages #607

Merged
merged 3 commits into from
Dec 25, 2023
Merged

Simplify and improve the all modules pages #607

merged 3 commits into from
Dec 25, 2023

Conversation

tischi
Copy link
Collaborator

@tischi tischi commented Dec 9, 2023

Hi,

I made some modifications to our module overview page.

Currently, if one zooms out it looks like this:

image

After the changes in this PR it looks like this:

image

Doing this I also got rid of the Workflow and Scripting and Draft headings and instead added those terms as title prefixes, because:

  1. The rendering of the all modules page looks nicer without those headings
  2. It simplifies the code for creating this page a lot and thus will make this easier to maintain
  3. Any hierarchy is bound to break anyway ;-)
  4. It was not my original motivation, but a big advantage, imho, is that one can now put the workflows at the natural place where one would normally teach them

@tischi tischi requested review from manerotoni and tibuch December 9, 2023 11:28
@tibuch
Copy link
Collaborator

tibuch commented Dec 11, 2023

I ❤️ the idea!

Would it be possible to set a min-width for the boxes? Currently the min-width seems to small. If I render it and show it on half my screen it looks like this:
image

If I reduce the window with to a quarter it looks good again:
image

@tischi
Copy link
Collaborator Author

tischi commented Dec 12, 2023

Hi @tibuch,

Thanks for having a look!

Interestingly, in my screenshot the panel headings seem to be much smaller and thus I do not have the issue with the text overflowing. Maybe this also is a browser issue? Which browser did you use and does it behave the same if you use another browser?


We could try (one ruby www is responsive again)

in assets/css/bootstrap.css

    .panel {
      min-width: 150px; /* Adjust the value as needed */
    }

@tibuch
Copy link
Collaborator

tibuch commented Dec 18, 2023

I tried firefox and chrome and get the same behavior in both. .

The proposed change results in this:
image

@tischi
Copy link
Collaborator Author

tischi commented Dec 25, 2023

I added some more improvements; I think it is good enough now. I will merge it and then we can improve more later.

@tischi tischi merged commit dd2e8f3 into master Dec 25, 2023
1 of 2 checks passed
@tischi tischi deleted the all_modules branch December 25, 2023 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants