Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve spatial calibration figure and concept map #600

Merged
merged 4 commits into from
Sep 25, 2023

Conversation

tischi
Copy link
Collaborator

@tischi tischi commented Sep 24, 2023

Hi @manerotoni,

Could you have a look whether you agree with the proposed changes?

This is how it looks like now:

image image

@tischi tischi requested a review from manerotoni September 24, 2023 12:07
@manerotoni
Copy link
Collaborator

Hi tischi,
I have a few suggestion.
In the figure you also multiply index*spacing but in the concept map you refer to value and calibration. To me an index is an integer value so using value is redundant. In the concept map if you want to keep calibration add spacing as an extra term/synonim. (calibration, spacing)

The arrow in the figure is not clear that it refers to the pixel coordinate. Could you draw a small square around the pixel?

@tischi
Copy link
Collaborator Author

tischi commented Sep 25, 2023

In the figure you also multiply index*spacing but in the concept map you refer to value and calibration.

Should we also call it calibration in the figure instead? The thing is that if you look at the whole figure there is also a drawing for "spacing. "

image

What about we remove the word "spacing" entirely from the figure and just keep dx and dy?

To me an index is an integer value so using value is redundant.

The "value" refers to the gray value of the pixel; shall we rename it? We always make the point that a pixel has two properties, its indices and its value.

@tischi
Copy link
Collaborator Author

tischi commented Sep 25, 2023

The arrow in the figure is not clear that it refers to the pixel coordinate. Could you draw a small square around the pixel?

One would not be able to see it. We had a zoom in overlayed, but that was confusing...maybe we should take a picture with less pixels? We could downsample this image!

@manerotoni
Copy link
Collaborator

The arrow in the figure is not clear that it refers to the pixel coordinate. Could you draw a small square around the pixel?

One would not be able to see it. We had a zoom in overlayed, but that was confusing...maybe we should take a picture with less pixels? We could downsample this image!

I would draw a bigger pixel or just a dot. Downsampled image is an option. Or leave it like this.

@tischi
Copy link
Collaborator Author

tischi commented Sep 25, 2023

@manerotoni

Thanks! I think downsampled version would be most appropriate.

Could you please also comment on some things that I said a bit higher up (about the spacing a.s.o)?

@manerotoni
Copy link
Collaborator

I prefer dx and dy. And yes either spacing or calibration. Spacing I never use, I use pixel-dimensions, pixel-size. Some people write from the center distance, but you can also view as the length of the square. None

Now I get for values what it means. May be write "intensity value" here or leave it as it is. I think it is clear that a pixel has 2 attributes.

@tischi tischi merged commit 89843e5 into master Sep 25, 2023
@tischi tischi deleted the improve_spatial_calibration_figure branch September 25, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants