-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Contribution guide with git2r #91
Conversation
|
||
1. **Fork** the [popgenInfo repository](https://github.com/NESCent/popgenInfo)\* | ||
2. **Clone** your fork to your local machine.\* | ||
6. Checkout your master branch, **fetch** the changes from NESCent and **merge** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Intentional that 6. follows after 2.? I know that it will be rendered correctly anyway, but it sticks out when looking at the Rmd.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was originally 6, but then I moved it up and didn't bother changing it because I knew MD would take care of it.
Awesome work, Zhian! |
I've made the requested changes. Let me know if these work for you. |
from your GitHub fork to NESCent. Your pull request begins a process of open | ||
peer review where content, accuracy, and style are considered. If changes are | ||
suggested, you can make them on your fork and they will automatically be updated | ||
in your pull request. When all questions and concerns have been addressed, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't they will automatically be updated in your pull request better put as your pull request will be automatically updated with them?
One minor remaining comment (see commit comment), otherwise great! 👍 |
Done. Sent from my iPhone
|
Great work 👍 It is possible to add the sessionInfo to the commit message with git2r using
|
Thanks! That's a good tip; I'll include it in an update. |
I've created an Rmarkdown document to help with contributing via git2r. I'm thinking about rendering into a static markdown document so it doesn't run into problems with proxy errors. I'm attaching the rendered HTML and markdown files from my machine:
CWG2R.zip
We could include this guide as a link in CONTRIBUTING.md
Let me know what you think, @hlapp.