Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attempt to add images to deploy #157

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

attempt to add images to deploy #157

wants to merge 1 commit into from

Conversation

zkamvar
Copy link
Contributor

@zkamvar zkamvar commented Mar 3, 2016

I do not know if this would work, but this would allow people to
include images by specifying ![](../images/img.png) as opposed to
placing the entire URL of the master branch, where the image would
not exist.

@hlapp, would this work?

I do not know if this would work, but this would allow people to
include images by specifying ![](../images/img.png) as opposed to
placing the entire URL of the master branch, where the image would
not exist.
@hlapp
Copy link
Member

hlapp commented Mar 7, 2016

I've created a test and I don't see how this can work. Essentially this will put a folder ../images into the tar file, which will expand as such, meaning images/ will go into the wrong directory (i.e., one level up rather than current).

However, perhaps there is a way to accomplish this correctly by adding to the tar file. I haven't had time to investigate that yet.

@zkamvar
Copy link
Contributor Author

zkamvar commented Mar 7, 2016

Perhaps something like

deploy: html
    tar cf $(SITEARCH) include libs *.html *_files; \
    tar rf $(notdir $(SITEARCH)) images -C ../

@zkamvar
Copy link
Contributor Author

zkamvar commented Mar 7, 2016

But since the -C flag seems to only be for extraction, it might be better as

deploy: html
    tar cf $(SITEARCH) include libs *.html *_files; \
    cd ../; \
    tar rf $(notdir $(SITEARCH)) images; \
    cd -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants