Adding context to event and event series calendar #5110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gjvoosten
requested changes
Mar 6, 2025
| } | ||
| .flatMap(event => { | ||
| return [createCalendarEventFromEvent(event)].concat( | ||
| reportsToEvents(event.reports, false, null) |
There was a problem hiding this comment.
Should we allow the user here the choice between showing the advisorOrg and the interlocutorOrg as well, like in the ReportCalendar?
[If not, you're retrieving more report fields in EventCalendar.tsx than you actually need.]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When in the events show page, the reports calendar will know show the event as well as the reports.
When in the event series show page, the events calendar will also show all the events reports.
Closes AB#1269
User changes
Superuser changes
Admin changes
System admin changes
Checklist
repo#issue: Titletitle format and these 7 rules