Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add date and time to engagement popup on geo-map #5099

Merged
merged 1 commit into from
Mar 10, 2025
Merged

Add date and time to engagement popup on geo-map #5099

merged 1 commit into from
Mar 10, 2025
+7 −2

Conversation

jlnat
Copy link
Collaborator

@jlnat jlnat commented Feb 28, 2025 •
edited by gjvoosten
Loading

Update engagement popup on geo-map to display the date (and time) of the engagement.

Closes AB#1272

User changes

  • The engagement popups on geo-map should display a date (and time, if so configured in the dictionary)

Superuser changes

  • None

Admin changes

  • None

System admin changes

  • application.yml or anet-dictionary.yml needs change
  • db needs migration
  • documentation has changed
  • graphql schema has changed

Checklist

  • described the user behavior in PR body
  • referenced/updated all related issues
  • commits follow a repo#issue: Title title format and these 7 rules
  • commits have a clean history, otherwise PR may be squash-merged
  • added and/or updated unit tests
  • added and/or updated e2e tests
  • added and/or updated data migrations
  • updated documentation
  • resolved all build errors and warnings
  • opened debt issues for anything not resolved here

@jlnat jlnat force-pushed the AB-1272-add_time_to_engagement_popup branch from 7848df4 to 0dce0f8 Compare March 5, 2025 10:09
@jlnat jlnat requested a review from gjvoosten March 5, 2025 10:49
midmarch
midmarch approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@midmarch midmarch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

image

@jlnat jlnat force-pushed the AB-1272-add_time_to_engagement_popup branch from 0dce0f8 to 332fd2b Compare March 8, 2025 21:19
@jlnat jlnat requested a review from gjvoosten March 10, 2025 07:59
@gjvoosten gjvoosten merged commit 44e7a61 into main Mar 10, 2025
20 checks passed
@gjvoosten gjvoosten deleted the AB-1272-add_time_to_engagement_popup branch March 10, 2025 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gjvoosten gjvoosten gjvoosten approved these changes

@midmarch midmarch midmarch approved these changes

@pacodelcastillolopez pacodelcastillolopez Awaiting requested review from pacodelcastillolopez

Assignees
No one assigned
Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jlnat @gjvoosten @midmarch