Skip to content

Commit

Permalink
Only use inline import, remove the top level model import to avoid ci…
Browse files Browse the repository at this point in the history
…rcular dependency

Only use inline import, remove the top level model import to avoid circular dependency

Reference: #2395
  • Loading branch information
rushirajnenuji committed May 1, 2024
1 parent af0cbdd commit 28f6859
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/js/collections/Citations.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* global define */
"use strict";

define(['jquery', 'underscore', 'backbone', 'models/CitationModel'],
function($, _, Backbone, CitationModel) {
define(['jquery', 'underscore', 'backbone'],
function($, _, Backbone) {

/**
* @class Citations
Expand All @@ -18,7 +18,7 @@ define(['jquery', 'underscore', 'backbone', 'models/CitationModel'],
/** @lends Citations.prototype */{

model: function (attrs, options) {
// We use the inline require here in addition to the define above to
// We use the inline require here to
// avoid an issue caused by the circular dependency between
// CitationModel and Citations
var CitationModel = require('models/CitationModel');
Expand Down

0 comments on commit 28f6859

Please sign in to comment.