Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netcdfread: safer version handling for Conventions property #296

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

netcdfread: safer version handling for Conventions property #296

wants to merge 13 commits into from

Commits on May 17, 2024

  1. Account for Conventions property value edge case with 2x'CF-'

    @sadielbartholomew
    sadielbartholomew committed May 17, 2024
    Configuration menu
    Copy the full SHA
    2d204ea View commit details
    Browse the repository at this point in the history

  2. netcdfread: more robust processing of Conventions prop. w/ regex

    @sadielbartholomew
    sadielbartholomew committed May 17, 2024
    Configuration menu
    Copy the full SHA
    eafd464 View commit details
    Browse the repository at this point in the history

  3. netcdfread: consolidate regex Conventions value processing

    @sadielbartholomew
    sadielbartholomew committed May 17, 2024
    Configuration menu
    Copy the full SHA
    408765b View commit details
    Browse the repository at this point in the history

  4. netcdfread: prevent SyntaxWarning on invalid escape sequence

    @sadielbartholomew
    sadielbartholomew committed May 17, 2024
    Configuration menu
    Copy the full SHA
    5575cb5 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Allow more version ID'ing components in Conventions value regex

    @sadielbartholomew
    sadielbartholomew committed May 21, 2024
    Configuration menu
    Copy the full SHA
    9512e0a View commit details
    Browse the repository at this point in the history

  2. Support reading of files w/ conformant Conventions='CF-X.Y.Z-draft'

    @sadielbartholomew
    sadielbartholomew committed May 21, 2024
    Configuration menu
    Copy the full SHA
    1a5557b View commit details
    Browse the repository at this point in the history

  3. netcdfread: add test to cover conformant Conventions attr. values

    @sadielbartholomew
    sadielbartholomew committed May 21, 2024
    Configuration menu
    Copy the full SHA
    f4918f9 View commit details
    Browse the repository at this point in the history

  4. netcdfread: fix Conventions attr. processing to allow 'X.Y-draft'

    @sadielbartholomew
    sadielbartholomew committed May 21, 2024
    Configuration menu
    Copy the full SHA
    8cce328 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. netcdfread: escape period to fix Conventions processing regex

    @sadielbartholomew
    sadielbartholomew committed May 22, 2024
    Configuration menu
    Copy the full SHA
    8cfc237 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Update to account for cf-convention/discussions/321 findings

    @sadielbartholomew
    sadielbartholomew committed May 30, 2024
    Configuration menu
    Copy the full SHA
    7ddadd0 View commit details
    Browse the repository at this point in the history

  2. netcdfread testing: tidy TODOs & include further test cases

    @sadielbartholomew
    sadielbartholomew committed May 30, 2024
    Configuration menu
    Copy the full SHA
    27a8193 View commit details
    Browse the repository at this point in the history

Commits on Jun 4, 2024

  1. netcdfread: add file_version info. to debug logging

    @sadielbartholomew
    sadielbartholomew committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    3548381 View commit details
    Browse the repository at this point in the history

  2. Test read_vars file_version is set correctly w/ netCDF reading

    @sadielbartholomew
    sadielbartholomew committed Jun 4, 2024
    Configuration menu
    Copy the full SHA
    95baf2a View commit details
    Browse the repository at this point in the history