Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Zarr >=2.13.6 so we use new FSStore objects (instead of KVStore) #65

Merged
merged 5 commits into from
Mar 7, 2023

Conversation

valeriupredoi
Copy link
Collaborator

Closes #62 #64

@davidhassell and myself have agreed to pin Zarr to (alomost) latest so we don't use the older KVStore and hence the need to call a private function, see zarr-developers/zarr-python#1362 (comment)

fsref = self.zds.chunk_store._mutable_mapping.fs.references

changes to

fsref = self.zds.chunk_store.fs.references

with newer Zarrs. Many thanks to @rabernat for sorting me out in zarr-developers/zarr-python#1362

@valeriupredoi valeriupredoi added the enhancement New feature or request label Mar 7, 2023
@valeriupredoi valeriupredoi merged commit 56ad427 into main Mar 7, 2023
@valeriupredoi valeriupredoi deleted the fix_Bryan_voodoo branch March 7, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unit tests failing (OK for now after pinning Zarr)
1 participant