Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better "pre-flight" checking and refactoring of polar maps #358

Draft
wants to merge 18 commits into
base: main
Choose a base branch
from

Conversation

brianpm
Copy link
Collaborator

@brianpm brianpm commented Mar 7, 2025

This PR contains a very tiny change in the global maps script. It is a bug fix to reverse the logic when checking whether all the plots for a given variable have been made. This will speed up ADF runs that don't need to re-make those plots.

It does the same for the polar plots, but with a much more substantial refactoring of the script. I think that it produces all the same plots, but the code is more efficient and easier to read. Essentially it has a more elaborate "pre-flight" part of the code, where it figures out all the plots that will be made and keeps all the information about them in a dictionary, and then iterates through a list of these dictionaries to do the calculations. This reduces the complexity of the code a lot because it removes nested loops for all the variations. It also updates the polar plots script to use the adf_dataset module, which also reduces code.

If we confirm this works and we like the approach, I think we should open an issue to refactor the other standard plotting scripts to use this structure.

@brianpm
Copy link
Collaborator Author

brianpm commented Mar 7, 2025

@justin-richling -- Could you test this and confirm that it is generating the same plots as the current ADF script? I'm kind of excited to reduce the size of the script by this much, I hope I'm not missing anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant