-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better "pre-flight" checking and refactoring of polar maps #358
Draft
brianpm
wants to merge
18
commits into
NCAR:main
Choose a base branch
from
brianpm:fix_redo_checking
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@justin-richling -- Could you test this and confirm that it is generating the same plots as the current ADF script? I'm kind of excited to reduce the size of the script by this much, I hope I'm not missing anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a very tiny change in the global maps script. It is a bug fix to reverse the logic when checking whether all the plots for a given variable have been made. This will speed up ADF runs that don't need to re-make those plots.
It does the same for the polar plots, but with a much more substantial refactoring of the script. I think that it produces all the same plots, but the code is more efficient and easier to read. Essentially it has a more elaborate "pre-flight" part of the code, where it figures out all the plots that will be made and keeps all the information about them in a dictionary, and then iterates through a list of these dictionaries to do the calculations. This reduces the complexity of the code a lot because it removes nested loops for all the variations. It also updates the polar plots script to use the adf_dataset module, which also reduces code.
If we confirm this works and we like the approach, I think we should open an issue to refactor the other standard plotting scripts to use this structure.