unindent WebSocketHandler definition #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses the issue where there is an isinstance check in __del__ for the log handler that checks if the log handler is of type WebSocketHandler, and the WebSocketHandler is defined inside the else block that follows the attempt to import websocket and pythonjsonlogger. Since the WebSocketHandler class definition does not use anything from the websocket-client library directly, we can move the definition of it to be on the top level indent.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses the issue where there is an isinstance check in del for the log handler that checks if the log handler is of type WebSocketHandler, and the WebSocketHandler is defined inside the else block that follows the attempt to import websocket and pythonjsonlogger. Since the WebSocketHandler class definition does not use anything from the websocket-client library directly, we can move the definition of it to be on the top level indent.