Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in get_gerp_score_percentile.py and zero gerp scores #98

Open
saadarif opened this issue Dec 16, 2024 · 1 comment
Open

Error in get_gerp_score_percentile.py and zero gerp scores #98

saadarif opened this issue Dec 16, 2024 · 1 comment
Assignees
Labels
bug Something isn't working next version Include this issue into the next pipeline version

Comments

@saadarif
Copy link

saadarif commented Dec 16, 2024

In the following code:

def approx_percentile(p, bin_edges, total):
    # find the 99th percentile from the histogram
    p = 99
 .....

the value ofpis hard coded, so never takes on user supplied values as specified in the docs. I imagine this is not intended?

On a different note, most of the positions in my reference have a gerp score of zero (based on alignment against 101 genomes of outgroup taxa). My current understanding is that Gerp scores of <1 suggest no constraint on the positions. But info on the UCSC genome browser also suggests that gerp scores of 0 might be lack of alignment information.

@verku verku self-assigned this Dec 19, 2024
@verku verku added bug Something isn't working next version Include this issue into the next pipeline version labels Dec 19, 2024
@verku
Copy link
Collaborator

verku commented Dec 19, 2024

Hi! Thanks for reaching out! You are correct, this was a mistake. I'll publish a corrected script with the next pipeline version release!

It depends how divergent the species in your alignment are, but in general one can expect that many sites will be so divergent that there is not enough alignment information for a GERP score to be calculated and it will be set to zero.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working next version Include this issue into the next pipeline version
Projects
None yet
Development

No branches or pull requests

2 participants