Partial implementation with Opensearch serverless #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
March 15, 2024 15:18
…ry-api into opensearchclient
this is not currently necessary
I can't think of a good reason to need to extract these from the builder - if one ever pops up it's easy enough to put them back there
RegistrySearchRequestBuilder redesign
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
- implement member-of and member-of/member-of endpoints - implement RegistrySearchRequestBuilder methods matchFieldAnyOf() and matchFieldAnyOfIdentifiers()
…functions - apply default behaviour of resolving LID to latest-LIDVID and only allowing non-superseded results in output data - implement ProductsController.resolveIdentifierToLidvid() - implement member-of and member-of/member-of endpoints - important explanatory comment - implement members and members/members products subroutes
Refactor membership endpoints to support AOSS and add test cases
* remove blob from PdsProduct responses * fix the get credential scheduled configuration. wip on terraform * remove blob fields from kvp responses --------- Co-authored-by: thomas loubrieu <[email protected]>
Add newly refactored `/classes/{class}` endpoint
Update unstable-cicd.yaml per new default branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Partial re-implementation of the opensearch queries for the web modernization developments.
This implementation revised the design of the controllers, the error managment and the OpenSearch query builder to simplify it (hopefully).
So far, the rest of the code is left as-is. If some cleaning of unused classes is needed that will be done later.
This also includes an incomplete/non-working development for ticket #433
⚙️ Test Data and/or Report
Test with docker compose, see https://github.com/NASA-PDS/registry-api/?tab=readme-ov-file#integration-deployment
Or on dev account on MCP, with the terraform scripts in
./terrraformin this repository.♻️ Related Issues
Fixes #470