Fix for Nucleus Terraform is complaining about missing local IAM policy files if executed multiple times after terraform destroy

[ramesh-maddegoda]

🗒️ Summary

At the moment Nucleus Terraform scripts generates IAM policy files locally before creating the IAM roles. This works well if we only use terraform apply any number of time and then used terraform destroy only once. Executing terraform destroy deletes these locally generated policy files and any subsequent terraform destroy commands complain about missing policy files. There is a workaround for this by using git to restore the deleted placeholder IAM policy files (or manually copy and paste placeholder IAM policy files from template files). But this work around adds manual and confusing steps for someone who does a deployment.

This pull request introduces fully Terraform based IAM policies instead of JSON based IAM policy files, to avoid locally generated IAM policy files.

♻️ Related Issues

#133

[nutjob4life]

I tried to init this with Localstack but got Error: Incompatible provider version so this review is based on a visual inspection only—and is largely limited to the parts I mainly understand (secrets detection, Terraform basics) which look fine 👍

[tloubrieu-jpl]

Reviewed in breakout. Good to go.