Integrate the latest version 4.0.1 of harvest in Nucleus workflowNew harvest #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an environment variable instead of as a command
…H_CREDENTIAL_RELATIVE_URL and OPENSEARCH_ENDPOINT as envrionment variables
…rch_credential_relative_url as variables
…to auth for Harvest
ramesh-maddegoda
requested review from
tloubrieu-jpl,
nutjob4life,
sjoshi-jpl and
jordanpadams
as code owners
nutjob4life
reviewed
Nov 8, 2024
| <!-- Registry configuration --> | ||
| <!-- UPDATE with your registry information --> | ||
|
|
||
| <registry auth="/etc/es-auth.cfg">file://{efs_config_dir + '/connection.xml'}</registry> |
There was a problem hiding this comment.
I thought file: URL should be file:/… or file:///… but if this works, great!
nutjob4life
approved these changes
Nov 8, 2024
There was a problem hiding this comment.
Approved—this review is based on visual inspection:
- The secrets-detection, XML docs, and the Python parts I can definitely attest to
- I'm still a Terraform noobie so take this with a grain of salt
No local reproduction since my local Localstack still doesn't work (on my to-do list)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Summary
Integrate the latest version 4.0.1 of harvest in Nucleus workflow
♻️ Related Issues
Integrate the latest version 4.0.1 of harvest in Nucleus workflow #121