Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Github Actions CI, Badges #28

Merged
merged 4 commits into from
Dec 29, 2020
Merged

Conversation

gkjohnson
Copy link
Contributor

Fix #17

  • Adds Github Actions CI so a build, tests, and linting are all performed on commit and pull request (though build is not automatically committed so it still must be done manually before publish)
  • Adds an NPM and CI badge to the README

cc @camargo

If you can add lgtm.com integration I can uncomment the LGTM badge in the PR. Once everything is enabled and merged the badges will look like they do in the 3DTilesRendererJS project. I'm using this successfully internally so once this is merged I think we can make a final 2.0.0 release and publish. Other functions and features (like #19, #25) can be added in a patch release when I have time to work on them / have a need for them. Same with making a new emscripten build (#5)

Copy link
Member

@camargo camargo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@camargo camargo merged commit 126be8c into NASA-AMMOS:master Dec 29, 2020
@gkjohnson gkjohnson deleted the add-ci branch December 29, 2020 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI, badges
2 participants