Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demo update #346

Merged
merged 5 commits into from
Jun 6, 2023
Merged

Demo update #346

merged 5 commits into from
Jun 6, 2023

Conversation

gkjohnson
Copy link
Contributor

@gkjohnson gkjohnson commented Jun 5, 2023 •
edited
Loading

Related to #331

  • Remove globe controls
  • Add slightly modified OrbitControls that supports a more controllable pan plane
  • Adjust view frustum based on camera position to remove artifacts
  • Adjust the camera target based on raycast position
  • Bump the queue sizes up to improve download speeds

TODO

  • Update to latest three.js
  • Fix lat lon -> vector and back functionality
  • Add lat lon hash to jump to a position
  • Add tilt to the camera
image

@gkjohnson gkjohnson mentioned this pull request May 31, 2023
Closed
@gkjohnson
Copy link
Contributor Author

cc @snowzurfer - looks like the orbit controls plane panning is more limited than I thought but I've got something going that at least allows you to zoom in closer to the surface with the current controls. As you've suggested - a more customized version seems like it's going to be needed.

@gkjohnson gkjohnson merged commit a2b4b31 into master Jun 6, 2023
3 checks passed
@gkjohnson gkjohnson deleted the demo-update branch June 6, 2023 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@gkjohnson